[WIP] use spring boot autoconfigure instead of our hand rolled esconfig #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonenst
changed the title
this allows to use multiple addresses
jonenst
force-pushed
the
autoconfigureelasticsearch
branch
from
a70ab5b
to
8a18027
Compare
|
|
TODO: check if we can get the hosts from a different place than boot.autoconfigure.ElasticsearchConnectionDetails, so that if we stop using autoconfigure we still get the information. Does the final client expose this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows to use multiple addresses