Use notifications to manage parameter changes #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AAJELLAL <[email protected]>
Signed-off-by: AAJELLAL <[email protected]>
… handle-params-notification
… handle-params-notification
Signed-off-by: AAJELLAL <[email protected]>
Signed-off-by: AAJELLAL <[email protected]>
… handle-params-notification
Signed-off-by: AAJELLAL <[email protected]>
sBouzols
reviewed
Sep 13, 2024
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AAJELLAL <[email protected]>
… handle-params-notification
Signed-off-by: AAJELLAL <[email protected]>
SlimaneAmar
approved these changes
Sep 19, 2024
| @@ -80,6 +82,7 @@ public class NotificationService { | |||
| public static final String UPDATE_TYPE_STATE_ESTIMATION_FAILED = "stateEstimation_failed"; | |||
| public static final String UPDATE_TYPE_STATE_ESTIMATION_RESULT = "stateEstimationResult"; | |||
| public static final String UPDATE_TYPE_STATE_ESTIMATION_STATUS = "stateEstimation_status"; | |||
| public static final String UPDATE_TYPE_COMPUTATION_PARAMETERS = "computationParameters"; | |||
There was a problem hiding this comment.
Rename by computationParametersUpdated
| @@ -166,6 +169,15 @@ public void emitStudyChanged(UUID studyUuid, UUID nodeUuid, String updateType) { | |||
| .build()); | |||
| } | |||
|
|
|||
| @PostCompletion | |||
| public void emitStudyComputationParamsChanged(UUID studyUuid, ComputationType computationType) { | |||
There was a problem hiding this comment.
Rename by emitComputationParamsChanged
Signed-off-by: AAJELLAL <[email protected]>
sBouzols
reviewed
Sep 23, 2024
| @@ -643,6 +644,9 @@ private void createOrUpdateParametersAndDoChecks(UUID studyNameUserIdUuid, Strin | |||
|
|
|||
| message = output.receive(TIMEOUT, elementUpdateDestination); | |||
| assertEquals(studyNameUserIdUuid, message.getHeaders().get(NotificationService.HEADER_ELEMENT_UUID)); | |||
| message = output.receive(TIMEOUT, studyUpdateDestination); | |||
| assertEquals(UPDATE_TYPE_COMPUTATION_PARAMETERS, message.getHeaders().get(NotificationService.HEADER_UPDATE_TYPE)); | |||
|
|
|||
There was a problem hiding this comment.
could assert that it's certainly LOADFLOW in HEADER_COMPUTATION_TYPE here as well
sBouzols
reviewed
Sep 23, 2024
| @@ -656,6 +657,8 @@ public void testNonEvacuatedEnergyParameters() throws Exception { | |||
| .contentType(MediaType.APPLICATION_JSON) | |||
| .content(myBodyJson)).andExpect( | |||
| status().isOk()); | |||
| Message<byte[]> message = output.receive(TIMEOUT, studyUpdateDestination); | |||
| assertEquals(UPDATE_TYPE_COMPUTATION_PARAMETERS, message.getHeaders().get(NotificationService.HEADER_UPDATE_TYPE)); | |||
|
|
|||
There was a problem hiding this comment.
same, you don't test HEADER_COMPUTATION_TYPE here and elsewhere
sBouzols
approved these changes
Sep 23, 2024
…into handle-params-notification
|
|
In order to correct the first Circular dependency I extracted the computations notification types to a specific class : #620 They are not used anymore in NotificationService anyway and there are so many static string there that some structuration might be better. Do as you wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.