Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First timepoint implementation #612

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

First timepoint implementation #612

wants to merge 44 commits into from

Conversation

klesaulnier
Copy link
Contributor

No description provided.

LE SAULNIER Kevin added 30 commits September 6, 2024 08:58
feat: first implementation of timepoints
854b650 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
8b547f4
fix: tests
ede825a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
temporary commit
4debb85 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep implementing timepoints
fe39ef8 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
6202846
fix: some fixes before changing structure
14d84a2 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: remove abstract timepoints links
c1a186f 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: compilable version + changelogs
ae83bf8 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: keep fixing issues
702f984 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: creating study and network-modification working
436fddc 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep implementing timepoints
fbda22c 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: more and more functionnality working
1e8bfcc 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep fixing app
7a7a85a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
acfec1c
fix: node building
a31de48 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: other node creation
0bd65ee 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: copy/pasting node + modifications now applied on right variant
0aff56d 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: duplication / move modifications
41ceeef 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: get root reports now working
139168a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: study deletion
6e6426a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: clean code + checkstyle
83bb335 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: keep cleaning code
e2181f6 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: formatting
682ddef 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: study deletion
8a8a2f7 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: tests
fdc76d4 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: dynamic simulation tests
a13a4b6 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: more tests
04248b9 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: some more tests
1fd2a67 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: some more tests
9d6413b 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
souissimai
souissimai reviewed Oct 3, 2024
View reviewed changes
src/main/java/org/gridsuite/study/server/repository/StudyEntity.java

@Column(name = "caseName", nullable = false)
private String caseName;
@OneToMany(mappedBy = "study", cascade = CascadeType.ALL, orphanRemoval = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FetchType.LAZY ?

souissimai
souissimai reviewed Oct 3, 2024
View reviewed changes
src/main/java/org/gridsuite/study/server/repository/timepoint/TimePointEntity.java
@JoinColumn(name = "studyUuid")
private StudyEntity study;

@OneToMany(orphanRemoval = true, mappedBy = "timePoint", cascade = CascadeType.ALL)
Copy link
Contributor

@souissimai souissimai Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@ManyToOne(fetch = FetchType.LAZY)
@JoinColumn(name = "studyUuid", foreignKey = @ForeignKey(name = "time_point_entity_fk"))
private StudyEntity study;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should be better to add constraint name and fetchtype

fix: some more tests
6618d55 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
souissimai
souissimai requested changes Oct 4, 2024
View reviewed changes
...ava/org/gridsuite/study/server/networkmodificationtree/entities/TimePointNodeInfoEntity.java
private UUID id;

@ManyToOne
@JoinColumn(name = "timePointId",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

@ManyToOne
@JoinColumn(name = "timePointId", nullable = false, foreignKey = @ForeignKey(name = "fk_timepoint_node_info"))
private TimePointEntity timePoint;``

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add nullable false?

src/main/java/org/gridsuite/study/server/repository/timepoint/TimePointEntity.java Outdated
@Setter
@Entity
@Builder
@Table(name = "timepoint")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timePoint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@klesaulnier klesaulnier changed the title [WIP] First timepoint implementation First timepoint implementation Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souissimai souissimai souissimai requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klesaulnier @souissimai