-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get scanner details #1612
Merged
Merged
Get scanner details #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraemii
force-pushed
the
get-scanner-details
branch
3 times, most recently
from
April 3, 2024 12:22
9ccaebb
to
720656c
Compare
Kraemii
commented
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains an API change for the rename of scanner_preference
to scan_preference
and should only be included for the next Major Release
Kraemii
force-pushed
the
get-scanner-details
branch
2 times, most recently
from
April 3, 2024 15:02
6e70d84
to
13235e0
Compare
Kraemii
force-pushed
the
get-scanner-details
branch
from
April 3, 2024 16:04
13235e0
to
6c7bb3a
Compare
Moved API changes to a new PR #1615 |
jjnicola
previously approved these changes
Apr 4, 2024
It is now possible to reach the entrypoint /scans/preferences to get a list of all preferences available for a scan. All available preferences are hardcoded, as they are static.
Kraemii
force-pushed
the
get-scanner-details
branch
from
April 10, 2024 09:29
6c7bb3a
to
e63ab14
Compare
nichtsfrei
approved these changes
Apr 16, 2024
jjnicola
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename scanner preferences to scan preferences
Add get scanner details from OSP to the new scanner API as get scan preferences
Implement the new endpoint into Openvasd
The new endpoint is
/scans/preferences
and a simple get command should get something like:Jira: SC-1040