Add upgrade scripts for database files #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailox
force-pushed
the
ailox/feature/upgrade
branch
from
d03f820
to
598d8c2
Compare
Postgres changes the format of the database files on disk between major versions. This means that in order to upgrade a postgres database, it is not sufficient to just bump the container versions. To help with this process, we now can use migration scripts that will take care of updating the database version without the need of a manual dump/restore. Ref.: DEVOPS-1292
ailox
force-pushed
the
ailox/feature/upgrade
branch
from
598d8c2
to
d4bd1de
Compare
|
|
||
| # Initialize the new database, if it doesn't exist | ||
| if [ ! -s "${PGDATANEW}/PG_VERSION" ]; then | ||
| gosu postgres initdb -D ${PGDATANEW} |
There was a problem hiding this comment.
We can't use gosu because all containers start with a static UID and any cap dropped. In this case 999. You can test the container with docker run -u 999 ... . Maybe you have to delete the volume first.
https://github.com/greenbone/automatix/blob/main/compose/dev/components/opensight/asset-management/compose.yaml#L14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Postgres changes the format of the database files on disk between major versions. This means that in order to upgrade a postgres database, it is not sufficient to just bump the container versions.
To help with this process, we now can use migration scripts that will take care of updating the database version without the need of a manual dump/restore.
Why
pg_upgraderequires the new and old postgres binaries to be present, therefore the image now containstwo postgres versions in parallel. This does affect image size (~35MB increase), but not runtime memory
consumption, as only one version of postgres is ever running at the same time.
References
DEVOPS-1292
Checklist