Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix the check for including notes and overrides in results (backport #2305) #2309

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix: Fix the check for including notes and overrides in results (backport #2305) #2309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9619d8
Fix: Fix the check for including notes and overrides in results
a-h-abdelsalam Oct 9, 2024
8f0d537
Fix indentation
a-h-abdelsalam Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/gmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9727,16 +9727,16 @@
buffer_xml_append_printf (buffer, "<compliance>%s</compliance>", compliance);

if (include_notes
&& use_delta_fields
? result_iterator_delta_may_have_notes (results)
: result_iterator_may_have_notes (results))
&& (use_delta_fields
? result_iterator_delta_may_have_notes (results)
: result_iterator_may_have_notes (results)))

Check warning on line 9732 in src/gmp.c

View check run for this annotation

Codecov / codecov/patch

src/gmp.c#L9730-L9732 

Added lines #L9730 - L9732 were not covered by tests
buffer_result_notes_xml (buffer, result,
selected_task, include_notes_details, lean);

if (include_overrides
&& use_delta_fields
? result_iterator_delta_may_have_overrides (results)
: result_iterator_may_have_overrides (results))
&& (use_delta_fields
? result_iterator_delta_may_have_overrides (results)
: result_iterator_may_have_overrides (results)))

Check warning on line 9739 in src/gmp.c

View check run for this annotation

Codecov / codecov/patch

src/gmp.c#L9737-L9739 

Added lines #L9737 - L9739 were not covered by tests
buffer_result_overrides_xml (buffer, result,
selected_task, include_overrides_details,
lean);
Expand Down
Loading