Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Update directory name for assets url handler #170

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

a-h-abdelsalam
Copy link
Contributor

What

Update directory name for assets URL handler to assets instead of static and remove sub-directories.

Why

After switching to Vite as a build tool for GSA, all assets are placed by default in the assets directory without creating sub-directories for each type.

References

GEA-541

@a-h-abdelsalam a-h-abdelsalam requested review from mattmundell and a team as code owners April 24, 2024 14:30
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

After switching to Vite as a build tool for GSA, all assets are
placed by default in assets directory without creating subfolders
for each type.
Allow to use the gsad with old GSA versions and the in development one.
@bjoernricks bjoernricks enabled auto-merge (rebase) April 25, 2024 06:12
@bjoernricks bjoernricks merged commit f88fe83 into main Apr 25, 2024
8 checks passed
@bjoernricks bjoernricks deleted the update-assets-path branch April 25, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants