Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further flush out ability to auto-bind to functions and types. #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alancnet
Copy link

Hello, graphql-go authors.

I began this PR because I encountered a bug in BindFields where the name given to a type would be the JSON field name, which resulted in conflicts. I was using that function to automatically bind functions, and create types, so that the resolver functions themselves could be reused as regular exported functions.

I migrated that code into this project as well, as I feel it offers a significant improvement to dev experience.

type GreetingInput struct {
	Name string `json:"name"`
}

func Greeting(input GreetingInput) string {
	return fmt.Sprintf("Hello %s", input.Name)
}
...
rootQuery := graphql.ObjectConfig{Name: "RootQuery", Fields: graphql.Fields{
	"greeting": graphql.Bind(Greeting),
}}

or almost any manner of function along these lines:

func MyFunction(ctx context.Context, input MyFunctionInput) (output MyFunctionOutput, error) ...
func MyFunction(ctx *context.Context, input *MyFunctionInput) (output *MyFunctionOutput, error) ...
func MyFunction(ctx context.Context) (output MyFunctionOutput, error) ...
func MyFunction(input MyFunctionInput) (output MyFunctionOutput, error) ...
func MyFunction(input MyFunctionInput) (output MyFunctionOutput) ...
func MyFunction() (output MyFunctionOutput) ...
func MyFunction() (output string) ...

or constant

rootQuery := graphql.ObjectConfig{Name: "RootQuery", Fields: graphql.Fields{
	"version": graphql.Bind(1.1),
}}

Cheers!

-Alan 🤖

@coveralls
Copy link

coveralls commented Jul 28, 2020

Coverage Status

coverage: 91.721% (-0.3%) from 92.051% when pulling 9680004 on teamjobot:contrib into 4ebf270 on graphql-go:master.

…ing recursion.

Fix code coverage, support additional functions.

Add bind examples

Avoid errors where value IsZero

Add type tag, nested resolvers on Bind

Extend type

Don't call .Type() on zero values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants