chore: add a retry option for ipfs request #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM 👍🏼
As an improvement suggestion (which might not apply to this case):
The
ips.call(...)may fail for different reasons. Some of the errors reported may be unrecoverable (e.g., invalid host URL, invalid CID, remote host not found, etc.). In those cases, I would return from the retry loop as soon as that type of error is reported, as it is useless to retry a request that won't ever succeed.
tmigone
approved these changes
Apr 22, 2024
|
@LNSD Thanks for the suggestion. In a future version we can look at error types and what to retry. Here we asume all errors are recoverable else the oracle will consistently fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.