Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls insecure skip to analyze #9628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

heldertsantos
Copy link

What this PR does

What this PR does
Add -tls-insecure-skip-verify to analyze.
Currently, only the rules support using the -tls-insecure-skip-verify flag or the correspondent env var.

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@heldertsantos heldertsantos requested a review from a team as a code owner October 15, 2024 10:44
@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me. I've left a tiny ask to clean up the diff a bit.

Could you also add a changelog entry to the Mimirtool section, thank you.

rulerAnalyzeCmd.Flag("auth-token", "Authentication token bearer authentication; alternatively, set "+envVars.AuthToken+".").
Default("").
Envar(envVars.AuthToken).
StringVar(&raCmd.ClientConfig.AuthToken)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️
Can we keep this blank between different command definitions

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the new flag also be mentioned in a changelog entry please?

@aknuds1 aknuds1 added enhancement New feature or request component/mimirtool labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants