Report usages of the deprecated 'ext.loadimpact' option #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
force-pushed
the
report-loadimpact
branch
from
8c8bdf7
to
cd20b81
Compare
joanlopez
commented
Dec 2, 2024
| if err := lct.initRunner.SetOptions(configToReinject); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // Here, where we get the consolidated options, is where we check if any |
There was a problem hiding this comment.
I added it here because it looks like a considerably safe place among all the places configuration is read/written and manipulated in general, but any suggestion will be more than welcome.
There was a problem hiding this comment.
Also, note that this will be reported despite it's a local (k6 run) or a remote execution (k6 cloud), but I guess it's fine because a script that holds ext.loadimpact is still a candidate of experiencing issues if we remove such support.
In any case, if we want to get more accurate metrics (only cloud executions), we can always account reports with this and a test run id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It adds a new
deprecated_optionsfield into the usage reports, and accounts ifext.loadimpactis still being used, and how often.Why?
Because we likely will remove that option parameter before v1, so we need to make some plans.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Related with https://github.com/grafana/k6-cloud/issues/2210