-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dashboard information to v0.49.0 release notes #3544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.49.0 #3544 +/- ##
==================================================
Coverage ? 73.20%
==================================================
Files ? 267
Lines ? 20076
Branches ? 0
==================================================
Hits ? 14696
Misses ? 4466
Partials ? 914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
release notes/v0.49.0.md
Outdated
|
||
To access and download the report, click on the `Report` button located in the top right corner of the dashboard. | ||
|
||
![HTML Report Generated by k6 Dashboard](https://github.com/grafana/xk6-dashboard/blob/master/screenshot/k6-dashboard-html-report.png?raw=true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I'm wondering if both images should be embedded. For instance, the second image could remain a link, and customers could open and see a complete example of the report in a separate tab/window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same, I don't think I have a strong take on either way, although I find that this feature is very visual, and giving a visual clue is a good call to action. Maybe we keep the first image and keep the second as link instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we keep the first image and keep the second as link instead?
Yes, that's exactly what I was wondering, too 👍 It's essential to attract the attention of our customers, but I believe if both images are embedded, it could overload attention.
So 👍 for keeping the first image as it is and moving the second to a link, something like an example of the report you could find here or a better sugegstion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect wilco 👍🏻
What?
This PR adds a web-dashboard dedicated section to the release notes.