Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loadimpact/k6 Docker image from build process #3494

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

andrewslotin
Copy link
Contributor

What?

This PR updates the build pipeline to stop maintaining the loadimpact/k6 image on DockerHub.

Why?

Earlier this year we have announced that we will stop maintaining the loadimpact/k6 Docker image. For two years after k6 has joined Grafana we have been maintaining this image for backward compatibility and starting Dec 31st we will officially stop pushing updates to this image.

We expect grafana/k6 to be fully compatible and don't require any changes beyond updating the image name.

Checklist

  • I have performed a self-review of my code.

Related PR(s)/Issue(s)

Closes #3493

@olegbespalov olegbespalov added this to the v0.49.0 milestone Dec 7, 2023
@andrewslotin andrewslotin force-pushed the stop_building_loadimpact_k6 branch from 1ff9a3d to 7f578c9 Compare December 7, 2023 09:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df41f01) 73.20% compared to head (0e5baab) 73.21%.
Report is 5 commits behind head on master.

❗ Current head 0e5baab differs from pull request most recent head 7f578c9. Consider uploading reports for the commit 7f578c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3494   +/-   ##
=======================================
  Coverage   73.20%   73.21%           
=======================================
  Files         267      267           
  Lines       20090    20090           
=======================================
+ Hits        14707    14709    +2     
+ Misses       4468     4466    -2     
  Partials      915      915           
Flag Coverage Δ
ubuntu 73.14% <ø> (-0.01%) ⬇️
windows 73.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewslotin andrewslotin merged commit f67be4c into master Dec 7, 2023
21 checks passed
@andrewslotin andrewslotin deleted the stop_building_loadimpact_k6 branch December 7, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop maintaining the loadimpact/k6 Docker image
4 participants