Native ESM support #3456
Merged
Native ESM support #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
==========================================
+ Coverage 71.92% 71.93% +0.01%
==========================================
Files 291 290 -1
Lines 21277 21336 +59
==========================================
+ Hits 15303 15349 +46
- Misses 4915 4921 +6
- Partials 1059 1066 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
force-pushed
the
esm
branch
2 times, most recently
from
a77be99 to
27973ce
Compare
mstoykov
force-pushed
the
esm
branch
2 times, most recently
from
2ae2678 to
64053e8
Compare
mstoykov
added
the
breaking change
mstoykov
commented
Jul 9, 2024
mstoykov
force-pushed
the
esm
branch
2 times, most recently
from
bececd4 to
f083187
Compare
codebien
reviewed
Jul 9, 2024
This is still very hackish and tries to preserve every observable behavior possible. This also specifically skips adding support for: 1. dynamic import 2. Top level await - this is possible, but will require more changes 3. anything around the internal go modules having more functionality, which will likely require breaking changes Which will be added later. Also let us concentrate on making this change as not breaking as possible.
codebien
approved these changes
Jul 15, 2024
joanlopez
reviewed
Jul 15, 2024
| maxSrcLenForBabelSourceMapVarName = "K6_DEBUG_SOURCEMAP_FILESIZE_LIMIT" | ||
| sourceMapURLFromBabel = "k6://internal-should-not-leak/file.map" | ||
| ) | ||
| // A Compiler compiles JavaScript source code (ES5.1 or ES6) into a sobek.Program |
There was a problem hiding this comment.
Suggested change
| // A Compiler compiles JavaScript source code (ES5.1 or ES6) into a sobek.Program |
Looks like this comment is duplicated from the one below.
There was a problem hiding this comment.
I already have a branch that goes and fixes this and other comments, I would prefer to not block this PR on this.
There is going to quite a lot of cleanup either way.
joanlopez
approved these changes
Jul 15, 2024
oleiade
approved these changes
Jul 15, 2024
This was referenced Jul 18, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Native support for ESM in k6
Why?
Having native ESM support both allows us to use more goja features and drops our internal babel.
This also closes a number of js-compat issues as we no longer are blocked by babel not supporting something. As well as freeing up the ability for Sobek to add support for even newer things.
The
breaking changelabel is there as this both breaks oldrequirebehavior as part of #3534, but also now makes combining CommonJS and ESM syntax in one file a syntax error. The latter has been found to be a lot more common than the first, unfortunately. But there isn't any sane way to support that, and it also makes no sense to be mixed.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #3265