Skip to content

Commit

Permalink
wip: attemp to fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
na-- committed Jan 16, 2023
1 parent 8324c42 commit 2ce70fb
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions cmd/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1026,12 +1026,12 @@ func TestAbortedByScriptAbortInVUCodeInGroup(t *testing.T) {

t.Run("noLinger", func(t *testing.T) {
t.Parallel()
testAbortedByScriptTestAbort(t, true, script, runTestWithNoLinger)
testAbortedByScriptTestAbort(t, script, runTestWithNoLinger)
})

t.Run("withLinger", func(t *testing.T) {
t.Parallel()
testAbortedByScriptTestAbort(t, true, script, runTestWithLinger)
testAbortedByScriptTestAbort(t, script, runTestWithLinger)
})
}

Expand Down Expand Up @@ -1110,13 +1110,8 @@ func TestAbortedByInterruptDuringVUInit(t *testing.T) {
export default function () {};
`

// TODO: fix this to exect lib.RunStatusAbortedUser and
// exitcodes.ExternalAbort
//
// This is testing the current behavior, which is expected, but it's not
// actually the desired one! See https://github.com/grafana/k6/issues/2804
ts := getSimpleCloudOutputTestState(
t, script, nil, cloudapi.RunStatusAbortedSystem, cloudapi.ResultStatusPassed, exitcodes.GenericEngine,
t, script, nil, cloudapi.RunStatusAbortedUser, cloudapi.ResultStatusPassed, exitcodes.ExternalAbort,
)
asyncWaitForStdoutAndStopTestWithInterruptSignal(t, ts, 15, time.Second, "VU init sleeping for a while")
newRootCommand(ts.globalState).execute()
Expand Down

0 comments on commit 2ce70fb

Please sign in to comment.