Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart - Enable Leader Election only if replica count greater than one #463

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

hartman17
Copy link
Contributor

Addresses Issue #462

This will enable Leader election only when the K6 Operator deployment count is greater than one. This turns off a check that is not needed and keeps the operator logs clean.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@yorugac yorugac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartman17, thank you for the issue and the PR! This looks great: IMHO, it is preferable to have straight-forward logic to enable / disable leader election like here.

@yorugac yorugac merged commit 2fdcbb9 into grafana:main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants