Enrich errors with error source using grpc status package #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrowne
requested review from
andresmgot,
oshirohugo and
xnyo
and removed request for
a team
andresmgot
reviewed
Dec 10, 2024
ivanahuckova
approved these changes
Dec 12, 2024
| if IsDownstreamError(err) { | ||
| errorSource = status.SourceDownstream | ||
| } else if IsPluginError(err) { | ||
| errorSource = status.SourcePlugin | ||
| } | ||
|
|
||
| // Unless the error is explicitly marked as a plugin or downstream error, we don't enrich it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: