Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark sorting error in longRowProcessor as downstream #1099

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mark sorting error in longRowProcessor as downstream #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion data/time_series.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
"sort"
"strconv"
"time"

"github.com/grafana/grafana-plugin-sdk-go/experimental/errorsource"
)

// TimeSeriesType represents the type of time series the schema can be treated as (if any).
Expand Down Expand Up @@ -308,7 +310,7 @@ func (p *longRowProcessor) process(longRowIdx int) error {
}

if currentTime.Before(p.lastTime) {
return fmt.Errorf("long series must be sorted ascending by time to be converted")
return errorsource.DownstreamError(fmt.Errorf("long series must be sorted ascending by time to be converted"), false)
}

sliceKey := make(tupleLabels, len(p.tsSchema.FactorIndices)) // factor columns idx:value tuples (used for lookup)
Expand Down
Loading