Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disableProvenance option to GrafanaAlertRuleGroupSpec #1715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add disableProvenance option to GrafanaAlertRuleGroupSpec #1715

wants to merge 1 commit into from
+37 −5

Conversation

chenlujjj
Copy link

To resolve issue #1710

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chenlujjj chenlujjj mentioned this pull request Oct 15, 2024
Open
@chenlujjj chenlujjj force-pushed the feat/alertrule-disableprovenance-option branch from 729ddb1 to 807a92f Compare October 16, 2024 02:24
@theSuess theSuess mentioned this pull request Oct 16, 2024
Closed
@theSuess
Copy link
Member

Thanks for the quick PR! From the previous discussion, I think we can call the option editable. The terraform provider is auto-generated, which comes with the quirk of having hard to understand fields. Since we can simplify this for the user by calling it editable instead, I'd do that.

What's the take of the other maintainers on this?

@chenlujjj chenlujjj force-pushed the feat/alertrule-disableprovenance-option branch from 807a92f to 92132ed Compare October 17, 2024 11:50
@chenlujjj
Copy link
Author

@theSuess Thanks for the advice, I've updated the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baarsgaard Baarsgaard Baarsgaard left review comments

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@theSuess theSuess Awaiting requested review from theSuess theSuess is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenlujjj @CLAassistant @theSuess @Baarsgaard