Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numeric dataplane frame types #1067

Draft
wants to merge 3 commits into
base: dev-3.0.0
Choose a base branch
from
Draft

numeric dataplane frame types #1067

wants to merge 3 commits into from

Conversation

yesoreyeram
Copy link
Collaborator

This PR helps to add proper data frame types when the data frame is comply with numeric-wide/numeric-long data frame types.

This will help to handle the scenarios where these result types will be handled properly in alerts, recorded queries, server side expressions etc.

How to test

Before changes

  • Run grafana enterprise version with recorded queries setup
  • Open explore and execute the default json backend url query
  • Try setting up an recorded query out of it and you will see an error like this
image

After changes

  • Same query should produce valid recorded query results as shown below
image

@yesoreyeram yesoreyeram requested a review from a team as a code owner November 27, 2024 00:00
@yesoreyeram yesoreyeram changed the base branch from main to dev-3.0.0 December 1, 2024 23:22
@yesoreyeram yesoreyeram marked this pull request as draft December 1, 2024 23:28
@yesoreyeram yesoreyeram added this to the Version 3.0 milestone Dec 9, 2024
@yesoreyeram yesoreyeram self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebrandt kylebrandt kylebrandt left review comments

Assignees

@yesoreyeram yesoreyeram

Labels
version-3.0
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yesoreyeram @kylebrandt