Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our existing SQL heuristic was too lenient, we weren't detecting any specific protocols, but were simply searching for SQL text in the output. The simple heuristic is easy to defeat if we have a process that sends SQL like text in for example logs.
To fix this I added support for specific detection for MySQL and Postgres, while everything else will not be detected by default unless the user manually enables the SQL heuristic. This change doesn't affect Go, only protocol level detection.
While testing MySQL I also detected a few problems with HTTP calling to TLS enabled TCP requests. I've also fixed these in this PR. Mainly the issue was that related to SSL_write, where those Uprobes run before tcp_sendmsg. Therefore we were getting the connection information for the HTTP request and not the outgoing SSL write. This led to number of problems.
TODO:
Closes #1422