Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix informers on stale object deletion [1.9 backport] #1424

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Dec 2, 2024

Backport of PR #1420

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 42 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (fb6dbef) to head (0b4a918).
Report is 1 commits behind head on release-1.9.

Files with missing lines Patch % Lines
pkg/kubecache/meta/informers_init.go 57.57% 39 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1424      +/-   ##
===============================================
- Coverage        81.13%   80.95%   -0.18%     
===============================================
  Files              146      146              
  Lines            14731    14772      +41     
===============================================
+ Hits             11952    11959       +7     
- Misses            2199     2231      +32     
- Partials           580      582       +2     
Flag Coverage Δ
integration-test 58.50% <0.00%> (-0.23%) ⬇️
k8s-integration-test 59.92% <57.57%> (-0.21%) ⬇️
oats-test 34.00% <0.00%> (-0.10%) ⬇️
unittests 51.74% <26.26%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit cd2d312 into grafana:release-1.9 Dec 3, 2024
14 checks passed
@mariomac mariomac deleted the release-1.9 branch December 3, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants