Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heuristic: replace with # rather than with * #1418

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marevers
Copy link
Contributor

Closes #1410

Changes the route transform heuristic mode to replace route/path components (gibberish and numeric ids) with # rather than with *. This improves handling of label selectors, as the pound sign is not a regex token and does not interact with Prometheus regex handling, as opposed to the asterisk.

@marevers
Copy link
Contributor Author

I am not sure if in light of this change the wildCard constant should also be changed to /##.

const wildCard = "/**"

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.51%. Comparing base (043c46e) to head (ff40638).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   80.97%   78.51%   -2.47%     
==========================================
  Files         146      146              
  Lines       14843    14891      +48     
==========================================
- Hits        12019    11691     -328     
- Misses       2235     2594     +359     
- Partials      589      606      +17     
Flag Coverage Δ
integration-test ?
k8s-integration-test 60.01% <0.00%> (-0.04%) ⬇️
oats-test 34.00% <0.00%> (+0.10%) ⬆️
unittests 51.58% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using routes.unmatched: heuristic interferes with Prometheus/Grafana regex interpretation
2 participants