Use type alias for Template #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I pulled your branch and saw we're still importing upstream's template package into ours.
default_template.go:TemplateandFromGlobsare used in theForTestsfunction. Both of them are already part of ourtemplatepackage.default_template_test.go: This is a test file so I wouldn't worry about it.funcs.go:DefaultFuncsis taken from upstream.template_data.go: There are some public types and functions (ExtendData,TmplText) that use the upstream package.
I don't think the imported types could be a concern, but the ExtendData and TmplText functions would force us to use the upstream package if we want to use them. Is this something that we could run into?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR internalizes the usage of alertmanager's Template and updates all public functions and methods to use the type alias. This is a follow up for #63 (comment)