Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow slack GeneratorURL as link #109

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Jul 4, 2023

This PR address issue: #96

This will update the Slack responder to update the link under the following circumstances:

  • A single alert is fired and it as a GeneratorURL set (this should always be the case)
  • Multiple alerts are fired but they all have the same Generator URL (grouped by alertname)

Signed-off-by: Jared Quick <[email protected]>
Copy link
Contributor

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and works well. Thank you for your contribution!

Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – great contribution!

Copy link
Contributor

@konrad147 konrad147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@santihernandezc santihernandezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grobinson-grafana grobinson-grafana merged commit 0025eb4 into grafana:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants