Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ImageEditor brush colour is updated when changed #10041

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Nov 26, 2024

Description

The brush colour wasn't changing when a different color was selected, so it was always being set to red. The issue was in the Brush.sveltes initialisation of selected_color. It was using a reactive statement that kept resetting the colour back to the default value every time any dependencies changed.

Closes: #9105
Closes: #9066

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 26, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/31a85b6d47af65709679d89a26db6fc8ab4a8d7d/gradio-5.6.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@31a85b6d47af65709679d89a26db6fc8ab4a8d7d#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/31a85b6d47af65709679d89a26db6fc8ab4a8d7d/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/31a85b6d47af65709679d89a26db6fc8ab4a8d7d/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 26, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/imageeditor patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure ImageEditor brush colour is updated when changed

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair changed the title Ensure brush colour is updated when changed Ensure ImageEditor brush colour is updated when changed Nov 26, 2024
@freddyaboulton
Copy link
Collaborator

Will take a look first thing tomorrow!

@freddyaboulton
Copy link
Collaborator

Sorry mis-clicked lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants