Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: cmake compute features #14794

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 18, 2024

We diligently passed along the exact compute_* services that were enabled in the enable string.... but nothing consumed this information.

So remove some of the special compute handling.

For backwards compatibility reasons, we need to keep building compute if any of the compute_* features are requested. Emit a warning in this case that explains that compute is all or nothing.


This change is Reviewable

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (47b5bc2) to head (933278e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14794   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files        2319     2319           
  Lines      208231   208231           
=======================================
+ Hits       194224   194237   +13     
+ Misses      14007    13994   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review October 18, 2024 20:34
@dbolduc dbolduc requested a review from a team as a code owner October 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant