Slurm Exposed REST API Detector #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2024
tooryx
added
the
Contributor main
lokiuox
suggested changes
Nov 26, 2024
There was a problem hiding this comment.
Hey @lanced00m, thank you for your contribution!
I'm reviewing your plugin and I confirm it works correctly. I left a few comments on things that could be improved. Also, please update the first message with the link of the new testbed PR (google/security-testbeds#98)
Comment on lines
3
to
7
| This detector checks for exposed slurm REST API daemon by running an arbitrary command. | ||
|
|
||
| Ref: | ||
|
|
||
| - https://slurm.schedmd.com/rest.html |
There was a problem hiding this comment.
Please clarify here that the vulnerable configuration involves a reverse proxy to the API that does not check authentication and that the default REST API is secure.
Reference:
...rc/main/java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java
Outdated
Show resolved
Hide resolved
...java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Savio Sisco <[email protected]>
Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonVuLnDetectorTest.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java Co-authored-by: Savio Sisco <[email protected]>
…oogle/tsunami/plugins/detectors/rce/SlurmExposedRestApiDaemonDetector.java Co-authored-by: Savio Sisco <[email protected]>
…se) and TCS availability check"
|
@lokiuox, thank you for your comprehensive review! All issues are solved now, so you can check the PR again. |
lokiuox
suggested changes
Nov 28, 2024
There was a problem hiding this comment.
Hey @lanced00m, here's just a few more minor things to fix, then the plugin's good to go.
..._api/src/main/java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDetector.java
Outdated
Show resolved
Hide resolved
..._api/src/main/java/com/google/tsunami/plugins/detectors/rce/SlurmExposedRestApiDetector.java
Outdated
Show resolved
Hide resolved
lokiuox
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
LGTM - Approved
@maoning we can merge this and google/security-testbeds#98
Reviewer: Savio, Doyensec
Plugin: Slurm Exposed Rest API Detector
Drawbacks: None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#423
google/security-testbeds#98
I wrote this plugin based on this which has been merged recently with minimal changes as many as possible.