-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testbed for Joomla Improper AccessCheck in WebService Endpoint #92
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @am0o0, thanks for your contribution!
I confirm the testbed is working, I've left a few comments on a few very minor improvements.
Co-authored-by: Savio Sisco <[email protected]>
Co-authored-by: Savio Sisco <[email protected]>
Co-authored-by: Savio Sisco <[email protected]>
Co-authored-by: Savio Sisco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @am0o0,
after testing again I noticed that switching from one testbed to the other (safe to vulnerable and viceversa) could reuse the old containers, therefore triggering a false positive/negative. Added the name:
directives to mark the files as distinct from each other.
Co-authored-by: Savio Sisco <[email protected]>
Co-authored-by: Savio Sisco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PiperOrigin-RevId: 700778524 Change-Id: I4767ecdcb3a22065ef6ccdaae0ce8447f723f400
hello, this is according to the @leonardo-doyensec request in this issue:
google/tsunami-security-scanner-plugins#529