Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly handle lines that cross buffer boundaries. #902

Merged
merged 9 commits into from
Jul 17, 2024
Merged

fix: Correctly handle lines that cross buffer boundaries. #902

merged 9 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. feat: Add new LineReader struct to extract common code. 

    We explicitly check for reading across buffer boundaries in test.

Issue: #637
    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    02bae24 View commit details
    Browse the repository at this point in the history

  2. test: Rename tests to match an earlier rename.

    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    76b8221 View commit details
    Browse the repository at this point in the history

  3. refactor: Port the FifoStream to use the new LineReader. 

    Add a `Finish` function to clear out the last bytes at shutdown.
    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e856661 View commit details
    Browse the repository at this point in the history

  4. refactor: Migrate the SocketStream to use the new LineReader

    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d44be39 View commit details
    Browse the repository at this point in the history

  5. refactor: Migrate the DgramStream to use the new LineReader 

    Add a wrapping struct to add a Read method to the dgram connection.
    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c843c0b View commit details
    Browse the repository at this point in the history

  6. refactor: Migrate the FileStream to use the new LineReader. 

    Skip a test whose `want` is now invalid.
    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    de8cc1e View commit details
    Browse the repository at this point in the history

  7. refactor: Move the staleTimer into the LineReader.

    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    97cf805 View commit details
    Browse the repository at this point in the history

  8. chore: Clean up lint errors

    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ee521cd View commit details
    Browse the repository at this point in the history

  9. fix: Handle \r\n windows line endings.

    @jaqx0r
    jaqx0r committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b35d739 View commit details
    Browse the repository at this point in the history