refactor: Close the socketstream lines channel only once.

google · Jul 5, 2024 · 2681366 · 2681366
1 parent cf3931d
commit 2681366
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/internal/tailer/logstream/socketstream.go b/internal/tailer/logstream/socketstream.go
@@ -73,9 +73,7 @@ func (ss *socketStream) stream(ctx context.Context, wg *sync.WaitGroup, waker wa
 			glog.Info(err)
 		}
 		connWg.Wait()
-		if !ss.oneShot {
-			close(ss.lines)
-		}
+		close(ss.lines)
 	}()
 
 	var connOnce sync.Once
@@ -117,9 +115,6 @@ func (ss *socketStream) handleConn(ctx context.Context, wg *sync.WaitGroup, wake
 			glog.Info(err)
 		}
 		logCloses.Add(ss.address, 1)
-		if ss.oneShot {
-			close(ss.lines)
-		}
 	}()
 	ctx, cancel := context.WithCancel(ctx)
 	defer cancel()