Fix build warnings and errors on LCC (eLbrus C/C++ compiler) #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCC (eLbrus C/C++ compiler) is an EDG-based compiler that in most cases
is similar in behavior to GNU, but it has different warning options
supported and enabled by default. It seems to have sense to treat LCC
and GNU differently, as CMake supports it from 3.23.
For it to be done, CMake policy CMP0129 should be set to NEW,
and then CMAKE_${LANG}_COMPILER_ID may be checked to be STREQUAL "LCC".
This commit does this, and introduces warning arguments in call
to compiler that are slightly different from GNU to let googletest be
buildable without unexpected warnings.
There are four GetName<T>() functions that are expected to have a limited set of possible <T> types. But compiler does not know about that, and may complain (and in LCC case, does) about no return operator in the end of these functions. This commit adds dummy return to each of these functions to eliminate this warning.
__attribute__((optimize("no-optimize-sibling-calls"))) is not supported
for at least some versions of NVC (nVidia HPC compiler), and this case
has a workaround in gtest-port.h. Actually, this is true not just for
NVC (that defines __NVCOMPILER), but for other EDG-based compilers as
well, for example, LCC.
So the correct check here would be not just for __NVCOMPILER, but
for __EDG__ (NVC defines this too, because it is based on EDG).
This commit does this.
abi::__cxa_demangle("7MyArrayIbLi42EE", nullptr, nullptr, nullptr)
returns "MyArray<bool, 42>" on GCC/x86_64, but "MyArray<bool, (int)42>"
on LCC/e2k. This behavior causes googletest-list-tests-unittest test to
fail.
This commit fixes that by slightly modifying the regex to match this
behavior of abi::__cxa_demangle().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #4603.
Due to no discussion (and thus, no objections) in said issue, I decided to submit this PR without being explicitly asked to to do so. I hope this fits contributing guidelines.