Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4294] --gtest_break_on_failure conflicts with EXPECT_NONFATAL_FAILURE. #4406

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avrdan
Copy link

@avrdan avrdan commented Oct 31, 2023

Changes the behavior so that the flags --gtest_break_on_failure and --gtest_throw_on_failure no longer throw or raise signals for non-fatal failure, thus allowing execution to continue.

…t throw_on_failure. Updated googletest-throw-on-failure-test_.cc to set the throw_on_failure mode.
@higher-performance
Copy link
Collaborator

Note that you will almost certainly need to new tests for this (in addition to making sure all the existing ones pass, even disabled ones) to test all the edge cases you can, because I don't think we have tests for all of them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants