Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public API in View for transparent picking #8206

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add public API in View for transparent picking #8206

wants to merge 12 commits into from

Conversation

show50726
Copy link
Contributor

@show50726 show50726 marked this pull request as ready for review October 17, 2024 12:15
@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Oct 17, 2024
pixelflinger
pixelflinger requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

@show50726 show50726 closed this Oct 18, 2024
@show50726 show50726 reopened this Oct 18, 2024
@show50726
Copy link
Contributor Author

You also need to add the Java APIs as well as the Javascript ones (in js-bindings.cpp)

Done. I didn't notice that, thanks for the reminder:D

BTW, I noticed that there are some functions in View are not added to jsbindings.cpp (ex. View::setFrontFaceWindingInverted).
I'm wondering if that is on purpose? or some functions are missed and it would need a PR to fix them? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger pixelflinger requested changes

@poweifeng poweifeng Awaiting requested review from poweifeng

@bejado bejado Awaiting requested review from bejado

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Picking transparent renderables
2 participants
@show50726 @pixelflinger