Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Asset-Nior [en] layout #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Asset-Nior [en] layout #44

wants to merge 3 commits into from

Conversation

psiie
Copy link

@psiie psiie commented Nov 29, 2018

A lesser known keyboard layout which I use exclusively. Might as well add it in the chromeOS repo :).

This is such a small addition. Let me know if there is anything I could do to improve this release.

More info on Asset-Nior
http://millikeys.sourceforge.net/asset/

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@psiie
Copy link
Author

psiie commented Nov 29, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@bderrly bderrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the files related to assetxkb as that relies on the layout already existing in xkb which it does not. In dropping that directory you can move all of the files under assetmap up one level.

asset/assetmap/background.js Outdated Show resolved Hide resolved
asset/assetmap/background.js Outdated Show resolved Hide resolved
asset/assetmap/background.js Outdated Show resolved Hide resolved
asset/assetmap/manifest.json Outdated Show resolved Hide resolved
asset/assetmap/manifest.json Outdated Show resolved Hide resolved
@bderrly
Copy link
Contributor

bderrly commented Sep 19, 2020

@darkenvy are you still interested in merging this PR?

@psiie
Copy link
Author

psiie commented Sep 19, 2020

@darkenvy are you still interested in merging this PR?

Yes. Let me see what I can do about those changes :)

@google-cla
Copy link

google-cla bot commented Sep 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@psiie
Copy link
Author

psiie commented Sep 28, 2020

Updated MR and tested layout on ChromiumOS. All good to go :).
@bderrly, do you know if there is a way to override caps-lock? This keyboard layout uses caps-lock for backspace.

@google-cla
Copy link

google-cla bot commented Sep 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Sep 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@psiie
Copy link
Author

psiie commented Sep 28, 2020

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Sep 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@psiie
Copy link
Author

psiie commented Sep 28, 2020

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Sep 28, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

fixed locale

fixed major bug where chromeOS locks up

asset nior update after code review

asset nior; moved files
Copy link
Contributor

@bderrly bderrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest looking at the Lushootseed extension and copy a few of the things done there like adding the onBlur listener and checking that the contextID is still valid before calling commitText().

asset/manifest.json Outdated Show resolved Hide resolved
asset/README Outdated Show resolved Hide resolved
asset/background.js Outdated Show resolved Hide resolved
asset/background.js Outdated Show resolved Hide resolved
asset/background.js Outdated Show resolved Hide resolved
@psiie
Copy link
Author

psiie commented Jan 15, 2021

@bderrly, github says that there is "1 change requested" but I double checked and believe I got all of them. :)

@colmbuckley
Copy link
Collaborator

With apologies for the extended silence; I'm trying to pick up state on this project now and figure out how everything works. There's a small group of people in Google who still have access to the release keys etc.

@darkenvy Were you able to get Googlebot to recognize your CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants