Remove writeRecordsCsv, refactor the usage metrics task for Redshift #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeRecordsCsv
which worked on lists of a file's all recordsCsvRecordWriter
for writing records one at a timeOptional
withNullable
to simplify a helper methodRedshiftClusterUsageMetricsTask
RedshiftClusterUsageMetricsTask
We use a list of types of metrics in this connector. The refactor of the usage metrics task relies on that list being a constant. After merging this change, we still can introduce more metric types, but creating custom types of metrics dynamically would require a different approach.