Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove writeRecordsCsv, refactor the usage metrics task for Redshift #660

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

misolt
Copy link
Collaborator

@misolt misolt commented Nov 28, 2024

  • remove writeRecordsCsv which worked on lists of a file's all records
  • create CsvRecordWriter for writing records one at a time
  • replace Optional with Nullable to simplify a helper method
  • move the list of extracted cluster usage metric types to RedshiftClusterUsageMetricsTask
  • refactor record formatting in RedshiftClusterUsageMetricsTask

We use a list of types of metrics in this connector. The refactor of the usage metrics task relies on that list being a constant. After merging this change, we still can introduce more metric types, but creating custom types of metrics dynamically would require a different approach.

@misolt misolt changed the title Aws abstract Remove writeRecordssCsv, refactor the usage metrics task for Redshift Nov 28, 2024
@misolt misolt changed the title Remove writeRecordssCsv, refactor the usage metrics task for Redshift Remove writeRecordsCsv, refactor the usage metrics task for Redshift Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants