Output first and last query log entries for Teradata in summary section using shared state class #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misolt could you please review it? I implemented shared state approach and applied it for Teradata logs connectors for now, as this approach was the most voted one during discussion. If it is fine, later can apply for the rest of connectors. |
sayuzbas-google
changed the title
sayuzbas-google
added
enhancement
sayuzbas-google
changed the title
sayuzbas-google
requested review from
paolomorandini,
mjquinn-google,
arotenberg-google and
shevek-google
as code owners
dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/MetadataDumper.java
Show resolved
Hide resolved
misolt
reviewed
Oct 7, 2024
dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/MetadataDumper.java
Show resolved
Hide resolved
misolt
reviewed
Oct 7, 2024
...src/test/java/com/google/edwmigration/dumper/application/dumper/QueryLogSharedStateTest.java
Outdated
Show resolved
Hide resolved
misolt
reviewed
Oct 8, 2024
| @@ -265,9 +272,26 @@ private boolean checkRequiredTaskSuccess( | |||
| return true; | |||
| } | |||
|
|
|||
| private void outputFirstAndLastQueryLogEnries(SummaryLinePrinter linePrinter) { | |||
There was a problem hiding this comment.
It would be helpful to add tests for the logic inside this method
misolt
reviewed
Oct 8, 2024
| import java.util.concurrent.ConcurrentMap; | ||
|
|
||
| public class QueryLogSharedState { | ||
| public static final ConcurrentMap<QueryLogEntry, ZonedDateTime> queryLogEntries = |
There was a problem hiding this comment.
The concurrent collection suggests that this class is designed for use from multiple threads. If this is the case, please document how this is done - is it fully thread-safe and what rules need to be followed by developers using it. If any guarantees provided by the class aren't obvious then it's also good to document them.
misolt
reviewed
Oct 8, 2024
...app/src/main/java/com/google/edwmigration/dumper/application/dumper/QueryLogSharedState.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding first and last query log entries for Teradata and output in summary section of Dumper.
Current summary section:
Summary section with query log entries:
