--skipna FLAG added to weatherbench scripts.
#187
Merged
+412
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_683670091
branch
4 times, most recently
from
98fd0d8
to
35256b7
Compare
copybara-service
bot
changed the title
--skipna FLAG added in many places.--skipna FLAG added to weatherbench scripts.
copybara-service
bot
force-pushed
the
test_683670091
branch
4 times, most recently
from
c8aca3b
to
e379c03
Compare
To `evaluate.py`. Using this means NaN values are skipped in most metrics.
* The exceptions are
* `RankHistograms` ignores it (and logs if there are NaNs)
* SEEPS already effectively uses skipna
To other scripts
* `compute_averages`
* `compute_ensemble_mean`
* `resample_in_time`
The API convention is:
* Public methods have `skipna=False` default
* Private methods require `skipna`. Along the way, I updated a number of private methods to require all args. This lets typing ensure I've passed args down from public -> private.
PiperOrigin-RevId: 687319197
copybara-service
bot
force-pushed
the
test_683670091
branch
from
e379c03
to
5190bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skipnaFLAG added to weatherbench scripts.To
evaluate.py. Using this means NaN values are skipped in most metrics.RankHistogramsignores it (and logs if there are NaNs)To other scripts
compute_averagescompute_ensemble_meanresample_in_timeThe API convention is:
skipna=Falsedefaultskipna. Along the way, I updated a number of private methods to require all args. This lets typing ensure I've passed args down from public -> private.