Allow later compatible versions of xarray and pandas #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roansong
reviewed
Jul 4, 2024
setup.py
Outdated
| 'scipy', | ||
| 'scikit-learn', | ||
| 'xarray==2023.7.0', | ||
| 'xarray~=2023.7.0', |
There was a problem hiding this comment.
I don't think this is what we want. ~=2023.7.0 is equivalent to >=2023.7.0 ==2023.7.* which won't match any recent xarray versions (e.g. versions starting with 2024).
Are you sure you don't mean >=2023.7.0? The calendar versioning has the year as the major version, and no compatible version specifier (~=) allows a major version bump
There was a problem hiding this comment.
good catch thanks roan i didn't take note that xarray isn't using semvar. updated to use >=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both xarray and pandas currently have fixed versions in the setup.py which means it's fiddly to enable later versions of xarray if we're using weatherbench as a dep. In particular there's a number of improvements in xarray that are worth getting.
By changing the strict equals to the compatible release clause we can use newer versions whilst ensuring things don't break.