Agile modeling 16bit #685
Open
Agile modeling 16bit #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance as a parameter. Also rename references to "a2o"
…baw functionality to baw_utils
… are always float32
…also include 2-layer model (unfinished)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to allow classifier to run on embeddings with different dtypes.
Tests in
chirp/inference/tests/classify_test.pytest for different combinations of embedding and model dtypes and all combinations pass. However, it seems that the problem necessitating this change arises only when running a model of one dtype on a tfrecord dataset of a different type, as in https://github.com/QutEcoacoustics/perch/blob/8b24db69e8e5b980f6431c9b38b5e8b7cb414194/chirp/inference/tf_examples.py#L125, and the current classify_test.py does not include that. To be thorough, a test that does this should be added.This PR also includes a correction to the baw_utils api to allow the domain to be specified