Switch to pdbp 🏄🏼
#358
Switch to pdbp 🏄🏼
#358
Conversation
|
There's a new release of |
|
@mdmintz already tested manually and our test suite 🏄🏼 Should i pin to latest in our install script? |
|
@goodboy I'm working on the update for the extra highlighting you wanted. Should be ready soon. |
|
|
|
@mdmintz thanks! been trying it out the last day or so. I'm still slightly confused on the truncate defaults i think? |
|
A new release of |
Previously we were leaking our (pdb++) override into the Python runtime which would always result in a runtime error whenever `breakpoint()` is called outside our runtime; after exit of the root actor . This explicitly restores any previous hook override (detected during startup) or deletes the hook and restores the environment if none existed prior. Also adds a new WIP debugging example script to ensure breakpointing works as normal after runtime close; this will be added to the test suite.
|
Weird, debugger tests failed even though they didn't before? Removed the |
|
Only last thing was maybe removing the Not sure it's a big deal enough to block this and we probably won't get clarity until @mdmintz returns from vaca anyway 😂 So gonna land once stamped! |
A ton of thanks to @mdmintz for the fork and fix of
pdbppin the newand improved
pdbp: https://github.com/mdmintz/pdbpIt would seem pretty much all the outstanding issues we had with
pdbppare non-existent in the new project 💃🏼 , so i think other then running
this in my production dev eng for a bit, we can probably just land this
pronto 😎
Deatz of previous issues that seem to now be resolved:
pytesttop level root process wasn't usingpdbppon testcrashes (when using
--pdbpflag; seems completely resolved nowpyreplany more since thealt-lhotkeyi've been wanting works just fine in vim mode?
truncate_long_lines: boolwhich solves the whole resized-terminal-messes-with-vertical-line-spacing.
w/where/btoutput? mdmintz/pdbp#32