Skip to content

Commit

Permalink
Add a debug-mode-breakpoint-causes-hang case!
Browse files Browse the repository at this point in the history
Only found this by luck more or less (while working on something in
a client project) and it turns out we can actually get to (yet another)
hang state where SIGINT will be ignored by the root actor on teardown..

I've added all the necessary logic flags to reproduce. We obviously need
a follow up bug issue and a test suite to replicate!

It appears as though the following are required based on very light
tinkering:
- infected asyncio mode active
- debug mode active
- the `trio` context must breakpoint *before* `.started()`-ing
- the `asyncio` must **not** error
  • Loading branch information
goodboy committed Apr 16, 2023
1 parent 6358a87 commit 915664d
Showing 1 changed file with 47 additions and 9 deletions.
56 changes: 47 additions & 9 deletions examples/debugging/asyncio_bp.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,19 @@

import trio
import tractor
from tractor import to_asyncio


async def aio_sleep_forever():
await asyncio.sleep(float('inf'))


async def bp_then_error(
to_trio: trio.MemorySendChannel,
from_trio: asyncio.Queue,

raise_after_bp: bool = True,

) -> None:

# sync with ``trio``-side (caller) task
Expand All @@ -18,40 +25,57 @@ async def bp_then_error(
# we set `Lock.local_task_in_debug = 'sync'`, we probably want
# some further, at least, meta-data about the task/actoq in debug
# in terms of making it clear it's asyncio mucking about.

breakpoint()

# short checkpoint / delay
await asyncio.sleep(0.5)
raise ValueError('blah')

if raise_after_bp:
raise ValueError('blah')

async def aio_sleep_forever():
await asyncio.sleep(float('inf'))
# TODO: test case with this so that it gets cancelled?
else:
# XXX NOTE: this is required in order to get the SIGINT-ignored
# hang case documented in the module script section!
await aio_sleep_forever()


@tractor.context
async def trio_ctx(
ctx: tractor.Context,
bp_before_started: bool = False,
):

# this will block until the ``asyncio`` task sends a "first"
# message, see first line in above func.
async with (
tractor.to_asyncio.open_channel_from(bp_then_error) as (first, chan),

to_asyncio.open_channel_from(
bp_then_error,
raise_after_bp=not bp_before_started,
) as (first, chan),

trio.open_nursery() as n,
):

assert first == 'start'

if bp_before_started:
await tractor.breakpoint()

await ctx.started(first)

n.start_soon(
tractor.to_asyncio.run_task,
to_asyncio.run_task,
aio_sleep_forever,
)
await trio.sleep_forever()


async def main():
async def main(
bps_all_over: bool = False,

) -> None:

async with tractor.open_nursery() as n:

Expand All @@ -63,11 +87,18 @@ async def main():
loglevel='cancel',
)

async with p.open_context(trio_ctx) as (ctx, first):
async with p.open_context(
trio_ctx,
bp_before_started=bps_all_over,
) as (ctx, first):

assert first == 'start'
await trio.sleep_forever()

if bps_all_over:
await tractor.breakpoint()

# await trio.sleep_forever()
await ctx.cancel()
assert 0

# TODO: case where we cancel from trio-side while asyncio task
Expand All @@ -76,4 +107,11 @@ async def main():


if __name__ == '__main__':

# works fine B)
trio.run(main)

# will hang and ignores SIGINT !!
# NOTE: you'll need to send a SIGQUIT (via ctl-\) to kill it
# manually..
# trio.run(main, True)

0 comments on commit 915664d

Please sign in to comment.