-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh/knownhosts: fix hashed hostname component count in error message #287
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 59f185c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/578435. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578435. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/578435. |
Message from Nicola Murino: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578435. |
59f185c
to
62fb541
Compare
This PR (HEAD: 62fb541) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/578435. Important tips:
|
62fb541
to
de728ea
Compare
This PR (HEAD: de728ea) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/578435. Important tips:
|
Message from Nicola Murino: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578435. |
Correct the component splitting in the nextWord function to omit the initial empty element when decoding the pipe-separated hostname hash. Previously, the error message incorrectly counted this empty element, leading to misleading errors like: "knownhosts: got 3 components, want 3" This change makes the component split start from index 1. Tests for the error messages were added. Signed-off-by: Kimmo Lehto <[email protected]>
de728ea
to
521524c
Compare
This PR (HEAD: 521524c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/578435. Important tips:
|
Correct the component splitting in the nextWord function to omit the initial empty element when decoding the pipe-separated hostname hash.
Previously, the error message incorrectly counted this empty element, leading to misleading errors like:
knownhosts: got 3 components, want 3
This change makes the component split start from index 1.
Tests for the error messages were added.