-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mark go1.23 as minimum go version #3226
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the documentation for the Fiber framework, specifically regarding the required version of the Go programming language. The minimum supported version has been changed from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
👮 Files not reviewed due to content moderation or server errors (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3226 +/- ##
==========================================
- Coverage 82.82% 82.75% -0.08%
==========================================
Files 115 115
Lines 11287 11287
==========================================
- Hits 9349 9341 -8
- Misses 1539 1545 +6
- Partials 399 401 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50
.
Benchmark suite | Current: 2a285ee | Previous: 6702136 | Ratio |
---|---|---|---|
BenchmarkAppendMsgstorageManager |
0.6187 ns/op 1616.18 MB/s 0 B/op 0 allocs/op |
0.3106 ns/op 3219.54 MB/s 0 B/op 0 allocs/op |
1.99 |
BenchmarkAppendMsgstorageManager - ns/op |
0.6187 ns/op |
0.3106 ns/op |
1.99 |
BenchmarkAppendMsgdata |
0.6211 ns/op 1609.96 MB/s 0 B/op 0 allocs/op |
0.3103 ns/op 3222.33 MB/s 0 B/op 0 allocs/op |
2.00 |
BenchmarkAppendMsgdata - ns/op |
0.6211 ns/op |
0.3103 ns/op |
2.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Mark Go 1.23 as min go version in order to support new iterators.
Type of change
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/
directory for Fiber's documentation.Commit formatting
Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md