Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark go1.23 as minimum go version #3226

Merged
merged 1 commit into from
Dec 1, 2024
Merged

chore: mark go1.23 as minimum go version #3226

merged 1 commit into from
Dec 1, 2024

Conversation

efectn
Copy link
Member

@efectn efectn commented Dec 1, 2024

Description

Mark Go 1.23 as min go version in order to support new iterators.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to existing features and functionality)
  • Documentation update (changes to documentation)
  • Performance improvement (non-breaking change which improves efficiency)
  • Code consistency (non-breaking change which improves code reliability and robustness)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

  • Followed the inspiration of the Express.js framework for new functionalities, making them similar in usage.
  • Conducted a self-review of the code and provided comments for complex or critical parts.
  • Updated the documentation in the /docs/ directory for Fiber's documentation.
  • Added or updated unit tests to validate the effectiveness of the changes or new features.
  • Ensured that new and existing unit tests pass locally with the changes.
  • Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.
  • Aimed for optimal performance with minimal allocations in the new code.
  • Provided benchmarks for the new code to analyze and improve upon.

Commit formatting

Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md

@efectn efectn requested a review from a team as a code owner December 1, 2024 13:08
@efectn efectn requested review from gaby, sixcolors and ReneWerner87 and removed request for a team December 1, 2024 13:08
Copy link
Contributor

coderabbitai bot commented Dec 1, 2024

Walkthrough

The changes in this pull request primarily involve updates to the documentation for the Fiber framework, specifically regarding the required version of the Go programming language. The minimum supported version has been changed from 1.22 to 1.23 across various documentation files, including the README and installation guides. Additionally, several method signatures in the framework's code have been modified to enhance clarity and functionality, reflecting the updates in version 3 of Fiber.

Changes

File Path Change Summary
.github/README.md Updated Go version requirement from 1.22 to 1.23 in installation and limitations sections.
docs/intro.md Updated Go version requirement from 1.22 to 1.23 in the installation section.
docs/whats_new.md Documented significant updates in Fiber v3, including method signature changes and removal of support for Go < 1.23.
router.go Multiple method signature updates to unify handlers and middleware parameters.
app.go Updated method signatures for Test and NewCtxFunc to reflect new configurations and context handling.

Possibly related PRs

Suggested labels

🧹 Updates, v3

Suggested reviewers

  • sixcolors
  • gaby
  • ReneWerner87

🐰 In the land of code where the rabbits play,
We hop and we update, come what may!
With Go version raised, we leap with glee,
Fiber's new features are a sight to see!
So gather your carrots, let’s code and cheer,
For version three's here, let’s spread the cheer! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6702136 and 2a285ee.

⛔ Files ignored due to path filters (4)
  • .github/workflows/benchmark.yml is excluded by !**/*.yml
  • .github/workflows/linter.yml is excluded by !**/*.yml
  • .github/workflows/test.yml is excluded by !**/*.yml
  • go.mod is excluded by !**/*.mod
📒 Files selected for processing (3)
  • .github/README.md (3 hunks)
  • docs/intro.md (1 hunks)
  • docs/whats_new.md (1 hunks)
👮 Files not reviewed due to content moderation or server errors (3)
  • docs/intro.md
  • .github/README.md
  • docs/whats_new.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@efectn efectn added this to the v3 milestone Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (6702136) to head (2a285ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   82.82%   82.75%   -0.08%     
==========================================
  Files         115      115              
  Lines       11287    11287              
==========================================
- Hits         9349     9341       -8     
- Misses       1539     1545       +6     
- Partials      399      401       +2     
Flag Coverage Δ
unittests 82.75% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 2a285ee Previous: 6702136 Ratio
BenchmarkAppendMsgstorageManager 0.6187 ns/op 1616.18 MB/s 0 B/op 0 allocs/op 0.3106 ns/op 3219.54 MB/s 0 B/op 0 allocs/op 1.99
BenchmarkAppendMsgstorageManager - ns/op 0.6187 ns/op 0.3106 ns/op 1.99
BenchmarkAppendMsgdata 0.6211 ns/op 1609.96 MB/s 0 B/op 0 allocs/op 0.3103 ns/op 3222.33 MB/s 0 B/op 0 allocs/op 2.00
BenchmarkAppendMsgdata - ns/op 0.6211 ns/op 0.3103 ns/op 2.00

This comment was automatically generated by workflow using github-action-benchmark.

@ReneWerner87 ReneWerner87 merged commit 7762270 into main Dec 1, 2024
13 of 15 checks passed
@ReneWerner87 ReneWerner87 deleted the go1.23 branch December 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants