Use elements local property to generate proper JMS mappings #108
Conversation
composer.json
Outdated
| @@ -51,6 +51,11 @@ | |||
| "dev-master": "0.2-dev" | |||
| } | |||
| }, | |||
| "scripts": { | |||
| "tests": [ | |||
| "php ./vendor/phpunit/phpunit/phpunit -v" | |||
There was a problem hiding this comment.
i think that this is not needed. you can do just vendor/bin/phpunit (is short and works the same)
(this is just a minor note, no need to fix it for now)
Toilal
force-pushed
the
element-local-property
branch
2 times, most recently
from
697a496
to
9a19839
Compare
|
I'm working right now to narrow down the new test. |
|
👍 |
|
The part with the xsd reader has been merged, now I think that should be easier to work on this |
|
Let's try with @dev on xsd-reader. |
|
|
|
Maybe you could perform a release of xsd-reader, so we can merge this pull request with a stable version constraint on this dependency ? Then xsd2php could be released too ? PR on soap-client is only related to tests, so it can wait. |
Toilal
force-pushed
the
element-local-property
branch
from
40b7d8b
to
757f288
Compare
|
Thanks for the release of |
| // 'xml_element' => array( | ||
| // 'namespace' => 'http://www.example.com' | ||
| // ), | ||
| 'xml_element' => array( |
There was a problem hiding this comment.
is this the whole test? do we need something better?
There was a problem hiding this comment.
Sorry, I don't understand your question. What's the problem here ?
There was a problem hiding this comment.
Ho I see. You mean the test changes are too short for the fix ? I'll try to add more checks.
There was a problem hiding this comment.
In fact, the fix mostly relies on xsd-reader changes. xsd-reader carries a whole new test class for the use case, so i'm not sure it's required to bring more checks in xsd2php module.
|
I'm good with it! Thanks a lot for the hard work! |
Related to goetas-webservices/soap-client#46