Fix more cases of pages redirecting to themselves #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was "fixed" in b4ca6a7 (gocolly#763), but the fix turned out to be incomplete. That fix only allowed redirects leading to the same URL as the original destination, and didn't take into account more complicated cases. Such as, for example: * www.example.com * example.com * (set cookie) * example.com
WGH-
force-pushed
the
fix-self-redirect-again
branch
from
a8b1e36 to
02570f1
Compare
|
@asciimoo Can you maybe add WGH to your repository with merge permissions? I believe you are unable to maintain the project. Maybe add some people to help you out. |
|
I can merge, I just can't review my own MR :) |
melroy89
approved these changes
Jun 13, 2024
|
Unfortunately, no: I need a review by someone with write access |
In that case we need more maintainers. Since this is slowing down development by a lot! I'm also running big open source projects. And I embraced the C4 specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was "fixed" in b4ca6a7 (#763), but the fix turned out to be incomplete.
That fix only allowed redirects leading to the same URL as the original destination, and didn't take into account more complicated cases. Such as, for example: