Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord.RichPresence 2.0.5.0 #4663

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reiichi001
Copy link
Contributor

Now includes a setting to automatically run a Wine IPC Bridge for Linux users (if you need one).

XIV On Mac users should continue to use the Wine IPC Bridge available in the XOM program settings.

This change has no effect for Windows users of the plugin.

Now includes a setting to automatically run a Wine IPC Bridge for Linux users (if you need one).

XIV On Mac users should continue to use the Wine IPC Bridge available in the XOM program settings.

This change has no effect for Windows users of the plugin.
@bleatbot bleatbot enabled auto-merge (squash) October 10, 2024 01:04
@bleatbot
Copy link
Collaborator

bleatbot commented Oct 10, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 10 hours.

Name Commit Status
Dalamud.RichPresence [stable] 2c0e8a6 Build failed (Diff)
14 Needs (⚠️ 5 UNREVIEWED)
Type Name Version Reviewed by
NuGet DiscordRichPresence 1.2.1.24 ⚠️ NEW
NuGet Microsoft.NETCore.Platforms 2.0.0 ⚠️ Upd. from 3.1.0
NuGet Microsoft.Win32.Registry 4.5.0 ⚠️ Upd. from 4.7.0
NuGet System.Security.AccessControl 4.5.0 ⚠️ Upd. from 4.7.0
NuGet System.Security.Principal.Windows 4.5.0 ⚠️ Upd. from 4.7.0
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Oct 10, 2024
@reiichi001
Copy link
Contributor Author

If our build system doesn't like pulling the Wine IPC Bridge exe from Blooym's PR, then I can ship it directly or it can probably be reworked to be downloaded on demand.

@Blooym
Copy link
Contributor

Blooym commented Oct 10, 2024

I thought the build system could pull in files at build time but if not directly shipping would work fine too

@reiichi001
Copy link
Contributor Author

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Oct 10, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
Dalamud.RichPresence [stable] 2c0e8a6 Build failed (Diff)
14 Needs (⚠️ 5 UNREVIEWED)
Type Name Version Reviewed by
NuGet DiscordRichPresence 1.2.1.24 ⚠️ NEW
NuGet Microsoft.NETCore.Platforms 2.0.0 ⚠️ Upd. from 3.1.0
NuGet Microsoft.Win32.Registry 4.5.0 ⚠️ Upd. from 4.7.0
NuGet System.Security.AccessControl 4.5.0 ⚠️ Upd. from 4.7.0
NuGet System.Security.Principal.Windows 4.5.0 ⚠️ Upd. from 4.7.0
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001 reiichi001 added the pending-testing This plugin still needs to be tested. label Oct 17, 2024
@bleatbot
Copy link
Collaborator

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ Dalamud.RichPresence [stable] 0942007 v2.0.5.0 - Diff (160 lines, prev. 2.0.4.1) - Semantic
14 Needs (⚠️ 5 UNREVIEWED)
Type Name Version Reviewed by
NuGet DiscordRichPresence 1.2.1.24 ⚠️ NEW
NuGet Microsoft.NETCore.Platforms 2.0.0 ⚠️ Upd. from 5.0.0
NuGet Microsoft.Win32.Registry 4.5.0 ⚠️ Upd. from 5.0.0
NuGet System.Security.AccessControl 4.5.0 ⚠️ Upd. from 5.0.0
NuGet System.Security.Principal.Windows 4.5.0 ⚠️ Upd. from 5.0.0
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-small Diff for this PR is small. and removed build failed This plugin failed to build. labels Oct 17, 2024
@reiichi001
Copy link
Contributor Author

I'll need a Linux user to test this out. I think I adjusted paths correctly, but I'd like some eyes on that before its merged because I don't currently have a Linux machine ready for FFXIV.

@Blooym if you've got a moment, can you pull the artifact? (Otherwise, I can poke the linux channel for a sacrifice)

@reiichi001 reiichi001 removed the pending-testing This plugin still needs to be tested. label Oct 18, 2024
@reiichi001
Copy link
Contributor Author

I spun up a fedora machine and it worked there. This should be fine to merge now

@Blooym
Copy link
Contributor

Blooym commented Oct 19, 2024

Just tested and also worked fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small Diff for this PR is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants