Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Malmstone Calculator 1.0.0.0 #4494

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Conversation

pinapelz
Copy link
Contributor

A plugin that calculates how many matches of different PVP modes you have to play before reaching a certain series level in the current PVP Series

@bleatbot bleatbot enabled auto-merge (squash) August 28, 2024 19:23
@bleatbot
Copy link
Collaborator

bleatbot commented Aug 28, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

auto-merge was automatically disabled August 28, 2024 20:58

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 28, 2024

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@philpax
Copy link
Contributor

philpax commented Aug 29, 2024

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 29, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

😰MalmstoneCalculator [testing-live] - 9a39ca6 - Build system error: DalamudPackager output not found, make sure it is installed

Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Aug 29, 2024
@philpax
Copy link
Contributor

philpax commented Aug 29, 2024

Hmm, not sure why that build's failing. I'll try to get someone to look into it!


This plugin is now in the plugin review queue; we hope to get back to you soon!

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Aug 29, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Aug 29, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - 9a39ca6 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Aug 29, 2024
@pinapelz
Copy link
Contributor Author

Got it to work. Read goatcorp/Plogon#59 and saw that the folder name has to match InternalName

@bleatbot
Copy link
Collaborator

bleatbot commented Aug 29, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - c5bbbb9 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 1, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - be36dd0 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 1, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - 93da740 - v1.0.0.0 - Repo (New plugin)

Show log - Review

@bleatbot
Copy link
Collaborator

bleatbot commented Sep 1, 2024

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - 50877ad - v1.0.0.0 - Repo (New plugin)

Show log - Review

@philpax philpax removed the pending-code-review This plugin still needs code review. label Sep 1, 2024
@philpax philpax added the completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. label Sep 1, 2024
@bleatbot
Copy link
Collaborator

bleatbot commented Sep 4, 2024

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Malmstone [testing-live] - 93777d1 - v1.0.5.0 - Repo (New plugin)

Show log - Review

@pinapelz
Copy link
Contributor Author

pinapelz commented Sep 4, 2024

Not sure if its too late to add to the initial release since I know the code review has already happened.

Been using the plugin myself for the past week and felt like it was missing a few useful features:

  • Added option to show toast notification detailing current Series Level EXP progression after PVP Matches
  • Added option to show number of matches remaining until next Series Level in chat after PVP matches
  • Added option to automatically open plugin window when viewing Series Malmstone Rewards

Let me know if I should revert to the commit which the code review was done on

@philpax
Copy link
Contributor

philpax commented Sep 6, 2024

@philpax philpax added completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. labels Sep 6, 2024
@philpax philpax merged commit abbc4f8 into goatcorp:main Sep 6, 2024
2 checks passed
@philpax
Copy link
Contributor

philpax commented Sep 6, 2024

Tested by @sersorrel, all seems to work well.


Congratulations on your first plugin!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@pinapelz
Copy link
Contributor Author

pinapelz commented Sep 6, 2024

Thanks! My Discord is @pinapelz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants