Libvirt docs touchup #1127
Libvirt docs touchup #1127
Conversation
|
Rationale: |
|
Looks good but please squash these two commits into one and use the naming convention for commits on this project, ie:
Also be sure to add yourself to the |
|
@JJRcop until the issues I raised are addressed this still needs work. |
|
@majcosta Because you're using the GitHub website to make these changes, unless you download Git onto your computer (or a GUI client), you cannot complete the changes requested and will have to start over with a new Pull Request, keeping in mind to name your commit following our naming convention as noted. You may want to use github.dev to start over. It's an online VS code editor made by GitHub that lets you easily edit 2 or more files in the same commit. Otherwise, we won't make these changes for you. We recommend downloading a git client for best results especially if you plan to continue contributing to open source projects like Looking Glass in the future. |
majcosta
force-pushed
the
libvirt_docs_touchup
branch
from
94e2e9c
to
bf2010f
Compare
|
ok, done |
virt-manager (or libvirt itself) tends to preserve outer quotation marks but explode inner double-quotes into '"' which is annoying. this looks nicer when pasted into the XML editor and applied Also used double-quotes for the QEMU <6.2 example for consistency PS: added myself to AUTHORS since this is my first contribution
majcosta
force-pushed
the
libvirt_docs_touchup
branch
from
bf2010f
to
f183aee
Compare
if accepted, please squash