Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new right : See private task assign to my group #18314

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Nov 14, 2024

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !34489
  • Here is a brief description of what this PR does

Added a new right so that I can see the private tasks assigned to my group even if I can't see the basic private tasks.

Screenshots (if appropriate):

phpunit/functional/TicketTest.php Outdated Show resolved Hide resolved
src/CommonITILObject.php Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from Rom1-B November 20, 2024 16:44
trasher
trasher previously approved these changes Nov 22, 2024
@cedric-anne cedric-anne marked this pull request as draft November 25, 2024 08:15
Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed IRL, there is no need to add a new right. Private tasks assigned to a group should be visible from users that are part of this group as long as the user has the SEEPRIVATE right.

@cedric-anne cedric-anne marked this pull request as ready for review November 27, 2024 09:06
@cedric-anne cedric-anne dismissed trasher’s stale review November 27, 2024 09:06

changes were requested

@Rom1-B
Copy link
Contributor

Rom1-B commented Nov 27, 2024

If a profile has the SEEPRIVATE permission, it can view all private tasks, regardless of assignment. The goal here is to ensure that the user cannot see private tasks (thus without the SEEPRIVATE permission) except those assigned to one of their groups. I don’t have a strong opinion about the new permission, but I believe it adds more clarity to permission management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants